Fix regression in BufferedConsole after TS migration #8021
Conversation
|
Thanks @natealcedo! This exposed a regression in my migration of I pushed a fix and cleaned up the tests |
| super( | ||
| new Writable({ | ||
| write: message => | ||
| BufferedConsole.write(buffer, 'log', message, null, getSourceMaps()), |
There was a problem hiding this comment.
this should have been a type error - message was Buffer, not string
There was a problem hiding this comment.
I went with going back to the original implementation anyways, since the stack including lots of internal readable-stream frames. I had to pass 6 a level which felt really brittle
SimenB
changed the title
|
Great Stuff @SimenB! Was working on feature I've been thinking about implementing and noticed that the local build was failing on a project from work. I'll open an early PR on that feature to get feedback :) |
Codecov Report
@@ Coverage Diff @@
## master #8021 +/- ##
==========================================
- Coverage 64.11% 64.11% -0.01%
==========================================
Files 262 262
Lines 10170 10171 +1
Branches 1818 1818
==========================================
Hits 6521 6521
- Misses 3250 3251 +1
Partials 399 399
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR is to add an end to end test for #8020.
Fixes #8020